Review Request 109343: Remove filtered items from the model if their parent folder is collapsed

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109343/#review28838
-----------------------------------------------------------

Ship it!


I can't reproduce this bug with your patch anymore, all tests passed.

- Emmanuel Pescosta


On March 7, 2013, 9:47 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109343/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 9:47 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Very similar to https://git.reviewboard.kde.org/r/108976/. Basically, the same problem that happens when deleting expanded folders with hidden children is also there when collapsing the expanded folder.
> 
> The fix is the same. I mostly copied the code from slotItemsDeleted() to setExpanded(), rather than factoring it out, to make merging into master easier.
> 
> 
> This addresses bug 316335.
>     http://bugs.kde.org/show_bug.cgi?id=316335
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp d4c08a5 
>   dolphin/src/tests/kfileitemmodeltest.cpp b76f4be 
> 
> Diff: http://git.reviewboard.kde.org/r/109343/diff/
> 
> 
> Testing
> -------
> 
> Works for me, old and new unit tests pass.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130309/7058de3f/attachment.htm>