Review Request 111294: Dolphin: Use the Nepomuk2::FileMetaDatConfigWidget

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111294/#review35252
-----------------------------------------------------------

Ship it!


Thanks, looks good! I'd just remove the indentation of #includes for consistency.


dolphin/src/panels/information/filemetadataconfigurationdialog.cpp
<http://git.reviewboard.kde.org/r/111294/#comment25826>

    I'd remove the indentation here and two lines below (we don't indent either in other places in Dolphin where #includes are #ifdef'ed).


- Frank Reininghaus


On June 28, 2013, 1:47 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111294/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 1:47 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     Instead of the KFileMetaDataConfigurationWidget
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/filemetadataconfigurationdialog.h bd28f71 
>   dolphin/src/panels/information/filemetadataconfigurationdialog.cpp 99f799d 
> 
> Diff: http://git.reviewboard.kde.org/r/111294/diff/
> 
> 
> Testing
> -------
> 
> Shows the correct values
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130628/33f481b9/attachment.htm>