Review Request 111252: Re-enable expandable folders for network top level folders (remote:/)

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111252/#review35125
-----------------------------------------------------------

Ship it!


Thanks Emmanuel for your work to re-enable this feature! The patch looks good, and it works mostly fine, but I get a strange effect when expanding 'zeroconf' in remote: Expanding the fish/nfs/sftp subfolders and collapsing them does *not* result in their all of their children being removed from the model. Actually, chilItems() returns all children, but then removeItems() fails to find them in the model. Strange. It seems that m_itemData and m_items do not match, and indeed, if I add "Q_ASSERT(isConsistent());" at the end of insertItems(), it crashes. Debugging it further, I appears that there multiple indices which correspond to the same URL.

But it seems that this happens even without your patch, so I'd say that you can commit it. It would still be nice if we could find out what the problem is, but unfortunately, I'm not really familiar with the zeroconf stuff.

- Frank Reininghaus


On June 26, 2013, 10 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111252/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 10 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Re-enable expandable folders for network top level folders (remote:/)
> 
> Added a hash table for target url to url mapping. So when the dir lister
> sends us the target url as directory url, we can use the url mapping table
> to get the right "Dolphin internal" directory url, which is the non-target url.
> 
> 
> This addresses bug 306219.
>     http://bugs.kde.org/show_bug.cgi?id=306219
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h 1d2d8c1 
>   dolphin/src/kitemviews/kfileitemmodel.cpp f6b51f2 
> 
> Diff: http://git.reviewboard.kde.org/r/111252/diff/
> 
> 
> Testing
> -------
> 
> Works for me!
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130626/ccc27863/attachment.htm>