Review Request 111254: Fix the "dropped files are not selected" regression

Frank Reininghaus frank78ac at googlemail.com
Wed Jun 26 14:53:21 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111254/#review35123
-----------------------------------------------------------

Ship it!


Thanks, looks good! Nice that it could be solved just by correcting the wrong signal name. I had thought that it might be more complicated than that.

- Frank Reininghaus


On June 26, 2013, 12:06 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111254/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 12:06 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Fix the "dropped files are not selected" regression that has
> recently been brought up and that have been caused by review 107351 / commit
> fd65a97b0787b23246c9392fdc34173fb604c9ca
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp fa43656 
> 
> Diff: http://git.reviewboard.kde.org/r/111254/diff/
> 
> 
> Testing
> -------
> 
> Works for me!
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130626/f6c2a909/attachment.htm>


More information about the kfm-devel mailing list