Review Request 111226: Fix performance regression when loading many items in Details View

[Emmanuel Pescosta]

> On June 26, 2013, 10:50 a.m., Emmanuel Pescosta wrote:
> > dolphin/src/kitemviews/kfileitemmodel.cpp, line 779
> > <http://git.reviewboard.kde.org/r/111226/diff/1/?file=165623#file165623line779>
> >
> >     Please use the parentUrl instead of the directoryUrl here.

Hmm sry. Discard it please!

directory() returns the url from the dir lister, not from Dolphin internal.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111226/#review35112
-----------------------------------------------------------


On June 24, 2013, 9:14 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111226/
> -----------------------------------------------------------
> 
> (Updated June 24, 2013, 9:14 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The other day, I was going to reply to Emmanuel's comment in https://bugs.kde.org/show_bug.cgi?id=306290 and thought that I would better first compare how long loading a large folder takes in KDE/4.10 and master. To my surprise, I found that it was much slower in master, at least when using Details View.
> 
> The reason is that we receive the items from the dir lister in multiple bunches, and after the KFileItemModel changes, all these are inserted into the model immediately when Details View is used (in KDE/4.10, this is only done after the initial folder loading is finished). Inserting items in multiple bunches, however, is rather inefficient at the moment - even though all operations inside KFileItemModel are O(N) now, there are still some O(N^2) functions hidden in KItemListSizeHintResolver. This is worth fixing as well, of course. I'll look into that later.
> 
> The reason why there is a different treatment of the bunches at all in Details View is that we must make sure that parent items are in the model when we receive their children. I propose to only insert the pending items immediately if the new items are indeed children of an expanded folder.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp f6b51f2 
> 
> Diff: http://git.reviewboard.kde.org/r/111226/diff/
> 
> 
> Testing
> -------
> 
> Loading a large folder in Details View is significantly faster.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130626/58a88c24/attachment.htm>