Review Request 111233: Improve filterbar lock button

Commit Hook null at kde.org
Wed Jun 26 10:27:41 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111233/#review35099
-----------------------------------------------------------


This review has been submitted with commit 2756820e3697379f227ac7964bd034db8c2d07f6 by Kai Uwe Broulik to branch master.

- Commit Hook


On June 25, 2013, 10:55 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111233/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 10:55 a.m.)
> 
> 
> Review request for Dolphin, Aurélien Gâteau and Stuart Citrin.
> 
> 
> Description
> -------
> 
> Use the object-(un)locked icon, instead of the Lock Session icon which is really wrong for this purpose. Also make the button flat so it doesn't stick out so much. Makes it consistent with Gwenview's "Lock zoom" button.
> 
> (Wanted to create a screenshot but will not launch Dev Dolphin inside my session again as this always deletes all my Places entries)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/filterbar/filterbar.cpp 3fa9cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/111233/diff/
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130626/b7251549/attachment.htm>


More information about the kfm-devel mailing list