Review Request 111233: Improve filterbar lock button

[Christoph Feck]

> On June 25, 2013, 1:21 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! I wasn't aware that Gwenview has such a button (and I'm still unable to find it). The change looks good to me. About the flat/non-flat issue: I don't know. I would prefer to be consistent with other apps, but I understand that Gwenview and KMail take different approaches here?
> > 
> > "will not launch Dev Dolphin inside my session again as this always deletes all my Places entries":
> > 
> > This sounds like a very serious problem (I cannot reproduce though). Is there a bug report about that? Does only Dolphin master delete the entries, but not the 4.10 version?
> 
> Aurélien Gâteau wrote:
>     Gwenview lock button is only available through an hidden option: http://userbase.kde.org/Gwenview/Hidden_Configuration_Options#ShowLockZoomButton

Just to add one more opinion: The button would look better, if it was flat. The close button is also flat, and the lock button looks hovered, if it is raised. Actually, I was tempted to report it as a bug when I first saw it.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111233/#review35054
-----------------------------------------------------------


On June 25, 2013, 10:55 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111233/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 10:55 a.m.)
> 
> 
> Review request for Dolphin, Aurélien Gâteau and Stuart Citrin.
> 
> 
> Description
> -------
> 
> Use the object-(un)locked icon, instead of the Lock Session icon which is really wrong for this purpose. Also make the button flat so it doesn't stick out so much. Makes it consistent with Gwenview's "Lock zoom" button.
> 
> (Wanted to create a screenshot but will not launch Dev Dolphin inside my session again as this always deletes all my Places entries)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/filterbar/filterbar.cpp 3fa9cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/111233/diff/
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130625/83c543a5/attachment.htm>