Review Request 111233: Improve filterbar lock button

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111233/#review35047
-----------------------------------------------------------


Icon change definitely makes sense, it is also consistent with KMail.

I am ambivalent regarding whether the button should be flat or not. KMail uses a non-flat button (and put it on the left of the field). I for one would love for such icons to be embedded directly in KLineEdit itself, but that is not possible with the current API.

- Aurélien Gâteau


On June 25, 2013, 12:55 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111233/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 12:55 p.m.)
> 
> 
> Review request for Dolphin, Aurélien Gâteau and Stuart Citrin.
> 
> 
> Description
> -------
> 
> Use the object-(un)locked icon, instead of the Lock Session icon which is really wrong for this purpose. Also make the button flat so it doesn't stick out so much. Makes it consistent with Gwenview's "Lock zoom" button.
> 
> (Wanted to create a screenshot but will not launch Dev Dolphin inside my session again as this always deletes all my Places entries)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/filterbar/filterbar.cpp 3fa9cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/111233/diff/
> 
> 
> Testing
> -------
> 
> Tested, works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130625/ba09ecc3/attachment.htm>