Review Request 111197: Fix Bug 305694 - Zoom Slider fails to show correct icon size on mouse over...

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111197/#review34943
-----------------------------------------------------------


Thanks for the patch! In principle, the idea is good. However, I noticed a few small issues:

(a) When moving the slider by clicking on the left or right, the tool tip appears, but disappears immediately after the button is released. But maybe that's OK - I think we cannot do much about that in a simple way anyway, and the sliders in the settings dialog have the same issue.

(b) When the zoom level is changed by pressing Ctrl+"+"/Ctrl+"-" or by Ctrl+Wheel, the tool tip also appears and only disappears when the mouse is moved. That might also be OK, but it could also be irritating, I don't know.

I'm not saying that we should not include it, but I'd appreciate if other people would say what they think about it. Maybe we could try it in master then and see what the beta/RC testers say.

- Frank Reininghaus


On June 23, 2013, 1:41 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111197/
> -----------------------------------------------------------
> 
> (Updated June 23, 2013, 1:41 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Show the correct icon size in the zoom slider tooltip.
> 
> 
> This addresses bug 305694.
>     http://bugs.kde.org/show_bug.cgi?id=305694
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/dolphinstatusbar.cpp 068b632 
> 
> Diff: http://git.reviewboard.kde.org/r/111197/diff/
> 
> 
> Testing
> -------
> 
> Works with mouse wheel, dragging and clicking before or after the zoom slider button.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130624/f8eb1e3b/attachment.htm>