Review Request 111182: Fix ViewProperties crash on MacOS (caused by infinite recursion)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111182/#review34899
-----------------------------------------------------------


This review has been submitted with commit 04229f8f6c3b5c7732251ea4dd038b5fc81fc388 by Frank Reininghaus to branch KDE/4.10.

- Commit Hook


On June 22, 2013, 5:49 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111182/
> -----------------------------------------------------------
> 
> (Updated June 22, 2013, 5:49 p.m.)
> 
> 
> Review request for Dolphin and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
> When view properties are stored in each folder, but we enter a folder without .directory file, we try to read the global view properties instead. To achieve that, we enable global view properties, then create a new ViewProperties object, and disable global view properties again.
> 
> However, if changing the "global view properties" setting fails (which apparently happens for some reason on MacOS), this causes an infinite recursion. I propose to fix this by creating a ViewProperties object for an empty URL instead and ensuring that the global view properties are loaded if the constructor is called with an empty KUrl.
> 
> 
> This addresses bug 316209.
>     http://bugs.kde.org/show_bug.cgi?id=316209
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/viewproperties.cpp 30deb72 
> 
> Diff: http://git.reviewboard.kde.org/r/111182/diff/
> 
> 
> Testing
> -------
> 
> Works for me, no regressions so far. Testing on MacOS would be appreciated!
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130623/dd316d49/attachment.htm>