Review Request 111160: Fix Bug 294013 - cannot delete file inside tar archive

[Frank Reininghaus]

> On June 22, 2013, 7:34 a.m., Frank Reininghaus wrote:
> > Thanks for the patch! Nice work :-)

Thinking about it again, one could wrap the new lines in DolphinView in

if (m_selectionChangedTimer->isActive()) {
    ...
}

to prevent that the signal is emitted multiple times.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111160/#review34850
-----------------------------------------------------------


On June 21, 2013, 1:13 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111160/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 1:13 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Update the "Move to Trash" action's and the "Delete" action's enabled state in the context menu for read only files/folders (also archives).
> 
> 
> This addresses bug 294013.
>     http://bugs.kde.org/show_bug.cgi?id=294013
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinremoveaction.cpp 200fc40 
>   dolphin/src/views/dolphinview.cpp 303ee34 
> 
> Diff: http://git.reviewboard.kde.org/r/111160/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130622/90a52ec3/attachment.htm>