Review Request 111120: Also change the view mode, when the view properties settings file is not writeable.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111120/
-----------------------------------------------------------

(Updated June 22, 2013, 7:29 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

The problem is, that the new view mode will be saved to the view properties file on view mode change. 
After saving the new view mode, Dolphin re-reads the view properties file to get the new view
mode from this file to apply it to the view. 

Change View Mode => Save View Mode to the file => Read View Mode from the file => Apply it to the View

When the view properties file is not writeable, the view mode can not be changed with the current 
implementation.

This patch fixes this problem, because the view mode can always be changed, also if the properties file
is not writable. (Dolphin tries to save the View Mode on view mode change)

Change View Mode => Apply it to the View + Save View Mode to the file if possible


This addresses bug 318534.
    http://bugs.kde.org/show_bug.cgi?id=318534


Diffs
-----

  dolphin/src/views/dolphinview.h 62b5df7 
  dolphin/src/views/dolphinview.cpp d69d664 

Diff: http://git.reviewboard.kde.org/r/111120/diff/


Testing
-------

Works for me.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130622/6f59c48a/attachment.htm>