Review Request 111079: Restore the feature that multiple files with different extensions can be renamed without numbers

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111079/#review34793
-----------------------------------------------------------


This review has been submitted with commit 6f2e1403480bf5617b0cba92d6cbbbb4f62aec2c by Frank Reininghaus to branch KDE/4.10.

- Commit Hook


On June 17, 2013, 7:13 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111079/
> -----------------------------------------------------------
> 
> (Updated June 17, 2013, 7:13 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Actually, the idea of the "rename multiple files" feature is that the user provides a new name containing one or more '#'. The files are then renamed such that the '#' in the new name are replaced by numbers (1, 2, ... up to the number of renamed files), and the extensions are appended.
> 
> After I fixed https://bugs.kde.org/show_bug.cgi?id=318942 it turned out that it was actually possible to rename multiple files with different extensions without providing numbers. The patch broke this because it enables the "rename" button if and only if there is a contiguous sequence of '#' characters and the length of that sequence is at least 1.
> 
> Even though this feature was sort of accidental, I think that there are valid use cases for it, and it doesn't really hurt anyone. So I propose to restore it and enable the button also if there is no '#' in the string, and all renamed files have different extensions.
> 
> 
> This addresses bug 321234.
>     http://bugs.kde.org/show_bug.cgi?id=321234
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/renamedialog.h 18dca36 
>   dolphin/src/views/renamedialog.cpp a16bb95 
> 
> Diff: http://git.reviewboard.kde.org/r/111079/diff/
> 
> 
> Testing
> -------
> 
> Works for me, no regressions found so far.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130620/9d3a0c86/attachment.htm>