Review Request 111037: Places Panel: hide the "drop indicator" if an item is not hovered any more

Commit Hook null at kde.org
Thu Jun 20 18:30:33 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111037/#review34791
-----------------------------------------------------------


This review has been submitted with commit 92854f901df539068bd9e82a687e12d8928cdc5c by Frank Reininghaus to branch master.

- Commit Hook


On June 15, 2013, 9:57 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111037/
> -----------------------------------------------------------
> 
> (Updated June 15, 2013, 9:57 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> In master, try to drag an item in the places panel and move the mouse cursor down beyond the last item. Drop it in the empty space at the bottom of the panel -> nothing happens, but the "drop indicator" is still shown. See the screenshot: The mouse is hovering "Root" at the moment, and no button is pressed.
> 
> This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp c8c0fc5 
> 
> Diff: http://git.reviewboard.kde.org/r/111037/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the bug
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/PlacesPanelDragDrop.png
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130620/f1a13562/attachment.htm>


More information about the kfm-devel mailing list