Review Request 111011: KFileItemModelRolesUpdater polishing, step 3: try to do "fast" icon loading for all items
Commit Hook
null at kde.org
Thu Jun 20 18:23:08 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111011/
-----------------------------------------------------------
(Updated June 20, 2013, 5:23 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin.
Description
-------
This patch depends on https://git.reviewboard.kde.org/r/111008/ and https://git.reviewboard.kde.org/r/111009/
If we have successfully loaded all visible icons in 200 ms, spend the remaining time doing a "fast" icon loading, i.e., icon loading without known mime type, for all files. Note that this only works once David's kdelibs patch from http://lists.kde.org/?l=kfm-devel&m=137102348931280&w=2 is in master.
Diffs
-----
dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp e539b45
dolphin/src/kitemviews/kfileitemmodelrolesupdater.h aa47f17
Diff: http://git.reviewboard.kde.org/r/111011/diff/
Testing
-------
Works for me. No more unknown icons when scrolling even in large folders (like /usr/bin/) - when I scroll quickly to a position far away, preliminary icons are already there and are quickly replaced by "final" icons.
Thanks,
Frank Reininghaus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130620/c1b352f4/attachment.htm>
More information about the kfm-devel
mailing list