Review Request 111146: Fix Bug 299565 - Unnecessary repainting on mouse over when directory content is changing

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111146/#review34777
-----------------------------------------------------------

Ship it!


Good debugging! Just two small inline suggestions, if you think that they make sense, you can include them in your commit. Thanks!


dolphin/src/kitemviews/kfileitemmodel.cpp
<http://git.reviewboard.kde.org/r/111146/#comment25499>

    I think that you can move this assignment out of the loop, right? I don't know if the compiler is clever enough to see that.



dolphin/src/kitemviews/kfileitemmodel.cpp
<http://git.reviewboard.kde.org/r/111146/#comment25501>

    Now that you've determined the changedRoles, why not use them here? This might even save some work in other places (like when only the size and date of a file change when it's updated, but these are not shown at all in the view -> saves a relayouting).


- Frank Reininghaus


On June 20, 2013, 6:36 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111146/
> -----------------------------------------------------------
> 
> (Updated June 20, 2013, 6:36 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Avoid a unnecessary resorting when items are changed. 
> Only resort the items when the sorting role changes.
> 
> 
> This addresses bug 299565.
>     http://bugs.kde.org/show_bug.cgi?id=299565
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 5079b2f 
> 
> Diff: http://git.reviewboard.kde.org/r/111146/diff/
> 
> 
> Testing
> -------
> 
> Works for me
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130620/3274b445/attachment.htm>