Review Request 111144: Fix Bug 320897 - selection files with selection rectangle doesn't work if the rectangle has 0 pixel height

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Thu Jun 20 14:31:31 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111144/
-----------------------------------------------------------

(Updated June 20, 2013, 1:31 p.m.)


Review request for Dolphin.


Changes
-------

Use a translation vector instead of modifying x and y. 
I my opinion the code looks better with these changes ;)


Description
-------

Prevent the selection rectangle from being reduced to a 0px width
or a 0px height. So the selected items can not be accidently
unselected when the rectangle width/height becomes 0px.


This addresses bug 320897.
    http://bugs.kde.org/show_bug.cgi?id=320897


Diffs (updated)
-----

  dolphin/src/kitemviews/private/kitemlistrubberband.cpp ae023d2 

Diff: http://git.reviewboard.kde.org/r/111144/diff/


Testing
-------

Works for me.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130620/a55860a6/attachment.htm>


More information about the kfm-devel mailing list