Review Request 111102: Make it possible to find files like "a_b" using the keyboard search

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111102/#review34657
-----------------------------------------------------------

Ship it!


Works for me too!

- Emmanuel Pescosta


On June 18, 2013, 4:21 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111102/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 4:21 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The problem was that pressing "Shift", which resulted in adding an empty string to the current search, cancels the current search. I don't remember if there was a reason why it has been done this way. Apparently, the unit test used that method to clear the search, but if we apply that change to master only, we should be safe.
> 
> 
> This addresses bug 321286.
>     http://bugs.kde.org/show_bug.cgi?id=321286
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.cpp da8f72b 
>   dolphin/src/tests/kitemlistkeyboardsearchmanagertest.cpp cf15324 
> 
> Diff: http://git.reviewboard.kde.org/r/111102/diff/
> 
> 
> Testing
> -------
> 
> Works for me. Old and new tests pass.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130619/e897a80b/attachment.htm>