Review Request 110966: Do not use a fixed size for the widgets in the status bar

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110966/#review34558
-----------------------------------------------------------

Ship it!


Ship It!

- Emmanuel Pescosta


On June 12, 2013, 7:20 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110966/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 7:20 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The zoom slider, free space bar, and progress bar in the status bar have a fixed size since
> 
> http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=213450d39704fc0154da5f0e45e4198af8239842
> 
> This causes problems when the user tries to make the window more narrow, see bug 319373.
> 
> On the one hand, one could argue that the widgets need a certain size to be useful, but on the other hand, I think that we should not annoy the user if he/she really wants to have a narrow window.
> 
> The problem that translated space information might need more horizontal space and is thus not shown fully is still open (bug 318395). I'm not sure if this one can be fixed cleanly in Dolphin alone, or if some adjustments in KCapacityBar are required. It seems that the mimimumSizeHint of this class isn't even sufficient to show the text.
> 
> 
> This addresses bug 319373.
>     http://bugs.kde.org/show_bug.cgi?id=319373
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/dolphinstatusbar.h d7e37f5 
>   dolphin/src/statusbar/dolphinstatusbar.cpp 068b632 
> 
> Diff: http://git.reviewboard.kde.org/r/110966/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130618/8a3489db/attachment.htm>