Review Request 110970: Use Tab to switch between views

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110970/#review34306
-----------------------------------------------------------


Thanks Aurelién for the patch! It's true that switching between views with the keyboard is painful, to say the least. I also agree that Tab looks like an obvious choice, but I'm not sure if this could lead to problems (you already mentioned some).

I'm wondering if a cleaner approach would be to add create a new KAction in DolphinMainWindow that switches between views? We could use a default shortcut that is unlikely to cause conflicts, like Ctrl+Shift+Tab (or no default shortcut at all). And then people could just assign Tab to that action in the shortcut editor if they want. What do you think?

- Frank Reininghaus


On June 12, 2013, 10:29 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110970/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 10:29 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Use the Tab key to switch between views. It may be a bit worrying the way the Tab key is spied on, but it means it is still possible to use Tab and Shift-Tab to navigate other areas of the application. For example, pressing Shift-Tab while a view is focused places the focus on the last element of the url navigator. From there, one can use Shift-Tab and Tab to focus different elements of the navigator. Pressing Tab while on the last element of the navigator puts the focus back on the view.
> 
> 
> This addresses bug 171743.
>     http://bugs.kde.org/show_bug.cgi?id=171743
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 73001bf54e957c967b8203fc06af7556005f8d12 
>   dolphin/src/views/dolphinview.h d77a3a19806cbe8b1ecc1349b82009ef4c3db826 
>   dolphin/src/views/dolphinview.cpp 16b92801be73f6a299dff96c0a6c7506f03f6b42 
> 
> Diff: http://git.reviewboard.kde.org/r/110970/diff/
> 
> 
> Testing
> -------
> 
> Tested in single and splitted view. I noticed a few glitches, which you may or may not consider blockers:
> 
> - When the filter widget is visible, it cannot be focused by pressing tab anymore. It is still nevertheless possible to focus it with Ctrl+I or its access key.
> 
> - Same thing with the find widget. Still focusable with Ctrl+F.
> 
> - When one creates a new tab, the current view is not focused, so pressing "Tab" does not move the focus to the other view. I have the feeling this is independent from the patch and could be fixed y setting the focus to the view when a new tab is created.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130613/5d0b9707/attachment.htm>