Review Request 110908: When changing the URL while renaming inline, abort renaming, rather than renaming an item in the new folder

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110908/
-----------------------------------------------------------

(Updated June 10, 2013, 7:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

If the "role editor" loses focus, it considers the current renaming operation finished, and tells DolphinView to rename the file. This is a problem when changing the directory, because the URL change happens *before* DolphinView receives the signal, which results in a file in the new directory being renamed unexpectedly.

Currently, the DolphinView is connected to the "slotRoleEditingFinished" signal permanently. I propose to change this and only establish the connection when the "rename inline" editor is opened, and disconnect it when renaming is finished or canceled or the URL changes.


This addresses bug 319912.
    http://bugs.kde.org/show_bug.cgi?id=319912


Diffs
-----

  dolphin/src/views/dolphinview.h a2fe9f6 
  dolphin/src/views/dolphinview.cpp 502ffd4 

Diff: http://git.reviewboard.kde.org/r/110908/diff/


Testing
-------

Works for me.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130610/a3b41d5d/attachment.htm>