Review Request 110909: DO not rename the wrong item when items are added to the view while renaming

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110909/#review34018
-----------------------------------------------------------

Ship it!


Works for me too!

- Emmanuel Pescosta


On June 9, 2013, 10:23 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110909/
> -----------------------------------------------------------
> 
> (Updated June 9, 2013, 10:23 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The problem is that KItemListRoleEditor remembers the index of the item that is currently being renamed, and finally tells DolphinView to rename the item with that index. However, the index might change if new files are added to the directory.
> 
> To fix this, I propose to not tell KItemListRoleEditor about the index at all. Instead, just let the KStandardItemListWidget (which always knows about the correct index) determine the index when renaming is finished, and forward that one to DolphinView.
> 
> 
> This addresses bug 320823.
>     http://bugs.kde.org/show_bug.cgi?id=320823
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 386f60e 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp f0394df 
>   dolphin/src/kitemviews/private/kitemlistroleeditor.h aa2c977 
>   dolphin/src/kitemviews/private/kitemlistroleeditor.cpp 9f3b53c 
> 
> Diff: http://git.reviewboard.kde.org/r/110909/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130610/500f4ba0/attachment.htm>