Review Request 110686: Reduce KFileItemModel memory usage by implicitly sharing QByteArrays

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110686/#review33760
-----------------------------------------------------------

Ship it!


Great!

- Emmanuel Pescosta


On May 28, 2013, 4:44 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110686/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 4:44 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The summary says it all. The idea is based on http://milianw.de/blog/katekdevelop-sprint-vienna-2012-take-1
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h 1d837cb 
>   dolphin/src/kitemviews/kfileitemmodel.cpp d30d9e5 
> 
> Diff: http://git.reviewboard.kde.org/r/110686/diff/
> 
> 
> Testing
> -------
> 
> Opened a directory with 100000 files with the default view properties. Memory usage as reported by ksysguard is reduced from 309 MB to 280.5 MB.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130604/574ade57/attachment.htm>