Review Request 111805: Do not enable the "Create New..." menu when searching

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111805/#review36871
-----------------------------------------------------------

Ship it!


This makes sense so ship it!

- Emmanuel Pescosta


On July 30, 2013, 9:13 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111805/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 9:13 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> While an URL is being loaded, DolphinView assumes that the URL is not writable -> the "Create New..." menu is disabled.
> 
> When loading is completed, the dir lister's rootItem() is examined to decide if the URL is writable (I think that the reason for this approach is that examining it before the directory is loaded might take too long).
> 
> However, if the root item is "Null" (this happens to be the case for searches), we always assume that the URL is writable. I propose to change this default to "not writable". I don't see a problem here - can anyone imagine a situation where we have a view with a null root item that is writable?
> 
> Anyway, I'd prefer to push this to master only. The bug is not really a showstopper, and it doesn't hurt if it gets some wide testing before the commit ends up in a stable release.
> 
> 
> This addresses bug 321577.
>     http://bugs.kde.org/show_bug.cgi?id=321577
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 20bc9f5 
> 
> Diff: http://git.reviewboard.kde.org/r/111805/diff/
> 
> 
> Testing
> -------
> 
> The "Create New..." menu is disabled when searching. I haven't found any regressions so far.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130731/a8b7079c/attachment.htm>