Review Request 111692: Disable dragging panels out of the main window

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111692/#review36777
-----------------------------------------------------------


This review has been submitted with commit 5583fc635b1bfc96c096bce6c4fa2c28df4d279f by Frank Reininghaus to branch master.

- Commit Hook


On July 25, 2013, 4:14 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111692/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 4:14 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> If the panels are "unlocked", they can not only be moved to other positions at the edges of the main window. The user can also drag them out of the main window.
> 
> I believe that this feature is useful only for a small part of our user base. However, those users who do try to drag the panels out of the window will sometimes face quite annoying bugs.
> 
> Therefore, I propose to remove this feature in master. Changing it in 4.11 just before the release does not look like a good idea to me.
> 
> 
> This addresses bugs 288629, 322299 and 322812.
>     http://bugs.kde.org/show_bug.cgi?id=288629
>     http://bugs.kde.org/show_bug.cgi?id=322299
>     http://bugs.kde.org/show_bug.cgi?id=322812
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphindockwidget.cpp 0d8aea7 
> 
> Diff: http://git.reviewboard.kde.org/r/111692/diff/
> 
> 
> Testing
> -------
> 
> Cannot drag the panels out of the main window any more, and the corresponding bugs cannot be reproduced any more. The other panel features still work.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130729/97eeba5f/attachment.htm>