Review Request 111722: Do not select items unexpectedly when expanding a directory which has been copied and pasted together with its contents

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111722/
-----------------------------------------------------------

(Updated July 29, 2013, 9:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

The "Select all pasted items, even if they are not all created at the same time" feature caused a regression:

1. mkdir test && cd test && mkdir a b && touch a/1 a/2 && dolphin .
2. Switch to Details View, expand "a", select a, a/1, a/2, and copy (or drag) them.
3. Open another folder and paste (or drop) the items.
4. Move around in the destination folder (a is not selected any more then).
5. Expand a -> a/1 and a/2 become selected.

IMHO, this is unexpected and should be fixed. We can do that with KDirModel::simplifiedUrlList(urls), which we also use in other places to remove children from the list if their parents are already in the list.


Diffs
-----

  dolphin/src/views/dolphinview.cpp d54a101 

Diff: http://git.reviewboard.kde.org/r/111722/diff/


Testing
-------

Works for me, and I haven't seen any regressions yet.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130729/7c75b7d3/attachment.htm>