Review Request 111722: Do not select items unexpectedly when expanding a directory which has been copied and pasted together with its contents

[Frank Reininghaus]

> On July 28, 2013, 12:02 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/views/dolphinview.cpp, line 1103
> > <http://git.reviewboard.kde.org/r/111722/diff/1/?file=173813#file173813line1103>
> >
> >     Please remove this if, so that we always use the simplified urls.
> >     
> >     The problem is, when I paste items in Icon View or Compact View mode and change the view mode to Details View + expand the pasted folder, all items in this folder are selected.

Good idea, thanks! I thought we could save the call to KDirModel::simplifiedUrlList() (it sorts the list and then iterates through it to remove the children - seems needless if we are not in Details View), but I hadn't considered the "user changes the view mode after pasting" issue.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111722/#review36654
-----------------------------------------------------------


On July 26, 2013, 3:44 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111722/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 3:44 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The "Select all pasted items, even if they are not all created at the same time" feature caused a regression:
> 
> 1. mkdir test && cd test && mkdir a b && touch a/1 a/2 && dolphin .
> 2. Switch to Details View, expand "a", select a, a/1, a/2, and copy (or drag) them.
> 3. Open another folder and paste (or drop) the items.
> 4. Move around in the destination folder (a is not selected any more then).
> 5. Expand a -> a/1 and a/2 become selected.
> 
> IMHO, this is unexpected and should be fixed. We can do that with KDirModel::simplifiedUrlList(urls), which we also use in other places to remove children from the list if their parents are already in the list.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp d54a101 
> 
> Diff: http://git.reviewboard.kde.org/r/111722/diff/
> 
> 
> Testing
> -------
> 
> Works for me, and I haven't seen any regressions yet.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130728/cac7a497/attachment.htm>