Review Request 111692: Disable dragging panels out of the main window

[Frank Reininghaus]

> On July 25, 2013, 4:33 p.m., Kai Uwe Broulik wrote:
> > A few related bugs have recently been fixed, such as the "Panel doesn't disappear when minimizing" and I cannot reproduce the Terminal bug either.

Fair enough, but this still doesn't answer the question if the feature is useful at all, or at least sufficiently useful to justify that we accept that this feature causes bugs.

Even if the Terminal Panel issue is fixed now (I can still reproduce it, but maybe some of the repositories on my machine are not quite up-to-date), there is this style issue on Windows which prevents people from ever moving the panels back into the window again (and of course they blame us for it, even if it's not our fault at all). And maybe some other code which we have no control over will cause new problems with detached panels in the future.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111692/#review36499
-----------------------------------------------------------


On July 25, 2013, 4:14 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111692/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 4:14 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> If the panels are "unlocked", they can not only be moved to other positions at the edges of the main window. The user can also drag them out of the main window.
> 
> I believe that this feature is useful only for a small part of our user base. However, those users who do try to drag the panels out of the window will sometimes face quite annoying bugs.
> 
> Therefore, I propose to remove this feature in master. Changing it in 4.11 just before the release does not look like a good idea to me.
> 
> 
> This addresses bugs 288629, 322299 and 322812.
>     http://bugs.kde.org/show_bug.cgi?id=288629
>     http://bugs.kde.org/show_bug.cgi?id=322299
>     http://bugs.kde.org/show_bug.cgi?id=322812
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphindockwidget.cpp 0d8aea7 
> 
> Diff: http://git.reviewboard.kde.org/r/111692/diff/
> 
> 
> Testing
> -------
> 
> Cannot drag the panels out of the main window any more, and the corresponding bugs cannot be reproduced any more. The other panel features still work.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130728/ac9aa33c/attachment.htm>