Review Request 111557: Do not try to smooth-scroll past the end of the view

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111557/#review36186
-----------------------------------------------------------

Ship it!


Tested. Works fine for me too. Ship it!

- Emmanuel Pescosta


On July 18, 2013, 6:46 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111557/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 6:46 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> KItemListSmoothScroller::scrollTo(qreal position) does not check if 'position' is a valid value. Even if the view is scrolled to the bottom already, it tries to scroll further and activates "smooth scrolling" when the mouse wheel is used. Because it never gets out of the "smooth scrolling" state then, it gets confused when changing the directory, and restoring the correct scroll offset may fail.
> 
> Can be fixed easily by making sure that 'position' is in the valid range before initiating the smooth scrolling.
> 
> 
> This addresses bug 322212.
>     http://bugs.kde.org/show_bug.cgi?id=322212
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kitemlistsmoothscroller.cpp 6987e1c 
> 
> Diff: http://git.reviewboard.kde.org/r/111557/diff/
> 
> 
> Testing
> -------
> 
> Fixes the bug for me, and does not seem to cause any new problems so far.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130719/f521832c/attachment.htm>