Review Request 111486: Fixed the wrong calculation of the first and last visible index

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111486/#review36170
-----------------------------------------------------------



dolphin/src/kitemviews/kitemlistview.cpp
<http://git.reviewboard.kde.org/r/111486/#comment26777>

    Always trigger a offset changed request, because this function only emitts signals if the scroll values really changed. (Could happen because we recalculate the maximum scrolling offset and we check/adjust the scrolling offset in KItemListViewLayouter::doLayout())



dolphin/src/kitemviews/kitemlistview.cpp
<http://git.reviewboard.kde.org/r/111486/#comment26776>

    The layouter checks the scroll offset at the end of the layouting process, so no need to check it here again anymore.



dolphin/src/kitemviews/private/kitemlistviewlayouter.cpp
<http://git.reviewboard.kde.org/r/111486/#comment26779>

    This is the small "speedup" - replaces the lines from 515 up to 525.


- Emmanuel Pescosta


On July 19, 2013, 7:29 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111486/
> -----------------------------------------------------------
> 
> (Updated July 19, 2013, 7:29 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Fixed the wrong calculation of the first and last visible
> index in KItemListViewLayouter, which happened under some special
> circumstances (esp. when deleting items at the end of the view).
> 
> Also made a small performance improvement in KItemListViewLayouter::doLayout.
> We use the already calculated y bottom position instead of looping over
> all items, to determine the items "greatest" bottom position.
> 
> BUG: 319951
> FIXED-IN: 4.11.0
> 
> 
> This addresses bug 319951.
>     http://bugs.kde.org/show_bug.cgi?id=319951
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp 3bd8067 
>   dolphin/src/kitemviews/kitemlistview.h 6467b8c 
>   dolphin/src/kitemviews/kitemlistview.cpp d2b3fa1 
>   dolphin/src/kitemviews/private/kitemlistviewlayouter.h 306fcd3 
>   dolphin/src/kitemviews/private/kitemlistviewlayouter.cpp da569b3 
> 
> Diff: http://git.reviewboard.kde.org/r/111486/diff/
> 
> 
> Testing
> -------
> 
> Yep. No more icons rendered on top of each other. All items are visible after deleting some items at the end.
> 
> 
> File Attachments
> ----------------
> 
> Initial folder
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/initial.png
> Bug 302373 with Dolphin Master
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/master.png
> Bug 302373 with Dolphin Master + Patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/master_with_patch.png
> Bug 319951 with Dolpin Master (5 Items removed)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/snapshot9.png
> Bug 319951 with Dolphin Master + Patch (Same initial setup as snapshot 9 - 5 Items removed)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/snapshot10.png
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130719/e1ec19b4/attachment.htm>