Review Request 111486: Fixed the wrong calculation of the first and last visible index

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111486/
-----------------------------------------------------------

(Updated July 14, 2013, 12:42 p.m.)


Review request for Dolphin.


Description
-------

Fixed the wrong calculation of the first and last visible
index in KItemListViewLayouter, which happened under some special
circumstances (esp. when deleting items at the end of the view).

Also made a small performance improvement in KItemListViewLayouter::doLayout.
We use the already calculated y bottom position instead of looping over
all items, to determine the items "greatest" bottom position.

BUG: 319951
BUG: 302373
FIXED-IN: 4.11.0


This addresses bugs 302373 and 319951.
    http://bugs.kde.org/show_bug.cgi?id=302373
    http://bugs.kde.org/show_bug.cgi?id=319951


Diffs
-----

  dolphin/src/kitemviews/kitemlistview.cpp d2b3fa1 
  dolphin/src/kitemviews/private/kitemlistviewlayouter.cpp da569b3 

Diff: http://git.reviewboard.kde.org/r/111486/diff/


Testing
-------

Yep. No more icons rendered on top of each other. All items are visible after deleting some items at the end.


File Attachments (updated)
----------------

Initial folder
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/initial.png
Bug 302373 with Dolphin Master
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/master.png
Bug 302373 with Dolphin Master + Patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/master_with_patch.png
Bug 319951 with Dolpin Master (5 Items removed)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/snapshot9.png
Bug 319951 with Dolphin Master + Patch (Same initial setup as snapshot 9 - 5 Items removed)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/14/snapshot10.png


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130714/f9b9be8e/attachment.htm>