Review Request 111486: Fixed the wrong calculation of the first and last visible index

[Emmanuel Pescosta]

> On July 14, 2013, 9:41 a.m., Frank Reininghaus wrote:
> > Thanks for your efforts to fix these bugs! You said in bug 302373 that you found a way to reproduce the problem. Could you please share it with us? I'm afraid you patch doesn't really make it obvious to me what the real problem is. It seems that I'm also unable to reproduce bug 319951 in master.

> You said in bug 302373 that you found a way to reproduce the problem

1. Switch to the icons view mode
2. Scroll to the bottom
3. Verify that the last row has maximal "Items per Row - 1" items
4. Delete all items in the last row

Result: See Images initial.png, master.png and master_with_patch.png

> It seems that I'm also unable to reproduce bug 319951 in master.
Hmm I can reproduce it. See snapshot9.png and snapshot10.png


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111486/#review35924
-----------------------------------------------------------


On July 11, 2013, 4:20 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111486/
> -----------------------------------------------------------
> 
> (Updated July 11, 2013, 4:20 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Fixed the wrong calculation of the first and last visible
> index in KItemListViewLayouter, which happened under some special
> circumstances (esp. when deleting items at the end of the view).
> 
> Also made a small performance improvement in KItemListViewLayouter::doLayout.
> We use the already calculated y bottom position instead of looping over
> all items, to determine the items "greatest" bottom position.
> 
> BUG: 319951
> BUG: 302373
> FIXED-IN: 4.11.0
> 
> 
> This addresses bugs 302373 and 319951.
>     http://bugs.kde.org/show_bug.cgi?id=302373
>     http://bugs.kde.org/show_bug.cgi?id=319951
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.cpp d2b3fa1 
>   dolphin/src/kitemviews/private/kitemlistviewlayouter.cpp da569b3 
> 
> Diff: http://git.reviewboard.kde.org/r/111486/diff/
> 
> 
> Testing
> -------
> 
> Yep. No more icons rendered on top of each other. All items are visible after deleting some items at the end.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130714/6522bf0e/attachment.htm>