Review Request 111399: Keep the "item size hints" of moved items

Commit Hook null at kde.org
Fri Jul 5 18:45:46 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111399/
-----------------------------------------------------------

(Updated July 5, 2013, 5:45 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

Calculating the "item size hint", i.e., the size that is required to show an item including its full name, is quite expensive in Icons and Compact View. Therefore, it makes sense to keep them even if items are moved (the current code just throws them away and recalculates them the next time KItemListViewLayouter::doLayout() is called).


Diffs
-----

  dolphin/src/kitemviews/kitemlistview.cpp 2ea6657 
  dolphin/src/kitemviews/private/kitemlistsizehintresolver.h 5ec5f4a 
  dolphin/src/kitemviews/private/kitemlistsizehintresolver.cpp 5db87f3 

Diff: http://git.reviewboard.kde.org/r/111399/diff/


Testing
-------

When enabling the timer in KItemListViewLayouter::doLayout(), I see that the time required for a relayouting after changing the sort order or renaming a file is decreased significantly.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130705/d570746c/attachment.htm>


More information about the kfm-devel mailing list