Review Request 108543: KFileItemModelRolesUpdater: Avoid multiple updates for Nepomuk data

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108543/#review26057
-----------------------------------------------------------

Ship it!


Thanks, looks good!

- Frank Reininghaus


On Jan. 22, 2013, 12:24 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108543/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2013, 12:24 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
>     KFileItemModelRolesUpdater: Avoid multiple updates for Nepomuk data
>     
>     The Nepomuk ResourceWatcher emits 3 signals - propertyChanged,
>     propertyAdded and propertyRemoved. We should only listen to either the
>     propertyChanged signal or the propertyAdded + Removed signals. There is
>     no point in listening to all 3 signals. That will just result in
>     unnecessary updates.
>     
>     Additionally, we do not need to listen to the resourceCreated signal.
>     That is only emitted when we are watching for a specific types, which we
>     are not.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp ae93581 
> 
> Diff: http://git.reviewboard.kde.org/r/108543/diff/
> 
> 
> Testing
> -------
> 
> Updates work as expected.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130123/1d544b59/attachment.htm>