Review Request 108483: Make the "Folder cannot be dropped into itself" message less intrusive

Commit Hook null at kde.org
Tue Jan 22 06:18:35 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108483/#review25953
-----------------------------------------------------------


This review has been submitted with commit c10517314c46d511a6eb89ec7188d25d35b28959 by Frank Reininghaus to branch KDE/4.10.

- Commit Hook


On Jan. 19, 2013, 10 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108483/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 10 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Recent discussions and user feedback have shown that the error message that is shown when a folder is dropped on itself is too annoying because the KMessageWidget makes the view contents move (which is perfectly fine when a serious error prevents the directory from being opened and there are not items in the view at all).
> 
> As a short-term measure which is code-wise very unintrusive, I propose to just show the message in the status bar.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp f0fad19 
> 
> Diff: http://git.reviewboard.kde.org/r/108483/diff/
> 
> 
> Testing
> -------
> 
> Works and feels less annoying :-)
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130122/248d9d26/attachment.htm>


More information about the kfm-devel mailing list