Review Request 108443: [High-dpi issues] Fix Place edit dialog iconbutton fixed size

[Kai Uwe Broulik]

> On Jan. 16, 2013, 9:55 p.m., Commit Hook wrote:
> > This review has been submitted with commit 99f200d21b9b20059e4c391d07913b4bd2290e23 by Kai Uwe Broulik to branch KDE/4.10.
> 
> Christoph Feck wrote:
>     I think kdelibs/kfile has exactly the same issue, if you can confirm, please commit there, to.
> 
> Kai Uwe Broulik wrote:
>     See https://git.reviewboard.kde.org/r/108442
> 
> Christoph Feck wrote:
>     No, I mean the places editor dialog.

Ah, I see. The issue is in kfileplacesview.cpp which calls KFilePlaceEditDialog with a fixed 64px size.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108443/#review25698
-----------------------------------------------------------


On Jan. 16, 2013, 6:29 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108443/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 6:29 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> The KIconButton in the PlaceItemEditDialog is using fixed size KIconLoader::SizeLarge which is fixed to 48px. In most other places where KIconButton is used the size for desktop icons is used, which makes sense. This patch makes it use IconSize(KIconLoader::Desktop) for that button which defaults to 48px but scales.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemeditdialog.cpp f8b985f 
> 
> Diff: http://git.reviewboard.kde.org/r/108443/diff/
> 
> 
> Testing
> -------
> 
> Yup, see screenshot. With default settings you will not notice any difference.
> 
> 
> File Attachments
> ----------------
> 
> PlaceItemEditDialog with huge icons
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/dolphinplace.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130117/81fac687/attachment.htm>