Review Request 108443: [High-dpi issues] Fix Place edit dialog iconbutton fixed size

Kai Uwe Broulik kde at privat.broulik.de
Wed Jan 16 18:29:25 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108443/
-----------------------------------------------------------

Review request for Dolphin and Frank Reininghaus.


Description
-------

The KIconButton in the PlaceItemEditDialog is using fixed size KIconLoader::SizeLarge which is fixed to 48px. In most other places where KIconButton is used the size for desktop icons is used, which makes sense. This patch makes it use IconSize(KIconLoader::Desktop) for that button which defaults to 48px but scales.


Diffs
-----

  dolphin/src/panels/places/placesitemeditdialog.cpp f8b985f 

Diff: http://git.reviewboard.kde.org/r/108443/diff/


Testing
-------

Yup, see screenshot. With default settings you will not notice any difference.


File Attachments
----------------

PlaceItemEditDialog with huge icons
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/16/dolphinplace.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130116/68a3148b/attachment.htm>


More information about the kfm-devel mailing list