Review Request 108428: Allow Timeline-URLs as homepage

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108428/#review25696
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks good! Looks unintrusive and safe enough for KDE/4.10 to me (but note that there is the RC 3 freeze starting this night at 23:59 UTC).

> Imho should also be possible for activities so you can set eg. activities://current/

Oops, didn't even know that that URL exists. And I don't know what it's actually supposed to mean, it seems it doesn't show anything useful here.

> For 4.11 would be a cool idea to add buttons/list for some common places (such as your timeline, the current activity thing) to the home url dialog :)

Note that you already can click "Use Current Location" in the settings dialog already.

- Frank Reininghaus


On Jan. 15, 2013, 10:23 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108428/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2013, 10:23 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Timeline url cannot be set as homepage.
> 
> This patch adds an exception for them.
> 
> 
> This addresses bug 313151.
>     http://bugs.kde.org/show_bug.cgi?id=313151
> 
> 
> Diffs
> -----
> 
>   dolphin/src/settings/startup/startupsettingspage.cpp 633cdac 
> 
> Diff: http://git.reviewboard.kde.org/r/108428/diff/
> 
> 
> Testing
> -------
> 
> I did set timeline:/today/ as homepage in dolphin.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130116/c42cb7da/attachment.htm>