Review Request 105061: Blur tooltip backgrounds from Dolphin.

Kai Uwe Broulik kde at privat.broulik.de
Wed Jan 16 02:58:04 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105061/#review25629
-----------------------------------------------------------


I just wasn't able to compile dolphin because I didn't have plasma dev and deps set up. Imho it's a little overkill to link to Plasma just for this thing (I checked the code, this is the only thing that needs in Plasma). Isn't there a KWin method (since KWin is who does the blur stuff) we can use here? Imho would make Dolphin much easier to use on Windows.
Just my 0,02€

- Kai Uwe Broulik


On May 26, 2012, 1:43 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105061/
> -----------------------------------------------------------
> 
> (Updated May 26, 2012, 1:43 p.m.)
> 
> 
> Review request for Dolphin and Peter Penz.
> 
> 
> Description
> -------
> 
> Tooltips from dolphin are not blurred. This makes them blurred.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 0373d0e 
>   dolphin/src/views/tooltips/filemetadatatooltip.h 0f614d7 
>   dolphin/src/views/tooltips/filemetadatatooltip.cpp 840c216 
> 
> Diff: http://git.reviewboard.kde.org/r/105061/diff/
> 
> 
> Testing
> -------
> 
> Tested on both 4.8 and master (compile and run) and seems to be working just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130116/ccbf0fbb/attachment.htm>


More information about the kfm-devel mailing list