Review Request 108397: Make Create New and Recently Closed Tabs toolbar button not delayed

Frank Reininghaus frank78ac at googlemail.com
Mon Jan 14 09:27:45 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108397/#review25433
-----------------------------------------------------------

Ship it!


Thanks, good catch! I never knew that this toolbar buttons exist ;-) I agree that not making those menus delayed makes sense.

- Frank Reininghaus


On Jan. 13, 2013, 8:29 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108397/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2013, 8:29 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> By accident discovered that there is a "Create New" item available for the toolbar. Clicking it, however, does nothing. You have to long-press it (delayed popup menu). This patch fixes it for both entries. I think those two are the only actions (I found) that need this.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 11e03d0 
> 
> Diff: http://git.reviewboard.kde.org/r/108397/diff/
> 
> 
> Testing
> -------
> 
> Tested, added "Create New" and "Recently Closed Tabs" button to toolbar and clicked them. Menu appeared instantly.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130114/10af3e9e/attachment.htm>


More information about the kfm-devel mailing list