Review Request: Wrong icons selected after pasting files and renaming them (because there exists items with it's names)

[Frank Reininghaus]

> On Jan. 9, 2013, 2:18 p.m., Commit Hook wrote:
> > This review has been submitted with commit fd65a97b0787b23246c9392fdc34173fb604c9ca by Emmanuel Pescosta to branch master.
> 
> Emmanuel Pescosta wrote:
>     @Frank: Should I also push it to branch KDE/4.10? (Too much code changes??)

I'm really happy with the final result, and nobody has seen any problems with the patch yet. However, I still think that it should better get more testing before it's shipped to users in KDE 4.11 - we've seen regressions caused by commits which looked a lot more innocent :-(


The bug has been around for quite some time, so I think that it won't hurt much if users have to wait a little bit longer for a well-tested fix. One of the big benefits of a KDE 4.x release every 6 months is that people never have to wait long for a commit in master to reach them.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107351/#review25062
-----------------------------------------------------------


On Jan. 8, 2013, 10:18 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107351/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 10:18 p.m.)
> 
> 
> Review request for Dolphin, David Faure and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Bug 233335 - Wrong icons selected after pasting files and renaming them (because there exists items with it's names)
> 
> Dolphin 2.1 selects the existing items instead of the newly pasted + renamed items.
> 
> 
> This addresses bug 233335.
>     http://bugs.kde.org/show_bug.cgi?id=233335
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 11e03d0 
>   dolphin/src/dolphinviewcontainer.cpp 26a6803 
>   dolphin/src/panels/folders/folderspanel.cpp 6e3a767 
>   dolphin/src/panels/places/placespanel.cpp 61c15a7 
>   dolphin/src/views/dolphinview.h a2fe9f6 
>   dolphin/src/views/dolphinview.cpp f0fad19 
>   dolphin/src/views/draganddrophelper.h ac16f7c 
>   dolphin/src/views/draganddrophelper.cpp f81d4d0 
>   lib/konq/konq_operations.h b82feb4 
>   lib/konq/konq_operations.cpp e0f1ade 
> 
> Diff: http://git.reviewboard.kde.org/r/107351/diff/
> 
> 
> Testing
> -------
> 
> 1. Open a test folder with Dolphin.
> 2. Create the test files:
>     2.1. Open Dolphin’s terminal (F4).
>     2.2. Run “mkdir folder ; touch a b folder/b c d”.
>     2.3. Close Dolphin’s terminal (F4).
> 3. In the current folder, select the four empty files (a, b, c, d) and copy them (Ctrl+C).
> 4. Enter the “folder” folder.
> 5. Paste the files (Ctrl+V).
>     5.1. When asked for a new name for “b”, enter “b2” and hit Enter to continue.
> 
> Result:
> Items “a”, “b2”, “c”, “d” are selected
> 
> Btw. Thanks to Adrián Chaves Fernández for the easy way to test this bug ;)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130111/f34eab5d/attachment.htm>