Review Request: NepomukRunner: Redirect the 'nepomuk:/res/uuid' urls before opening them

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108305/#review25100
-----------------------------------------------------------

Ship it!


Please fix the coding style. I've pointed it out in two places, it's spaces around parentheses. The whole file seems a bit messy, so I guess you just picked the wrong example. :)

Please commit to KDE/4.10 and master once the coding style is corrected (in your patch, no need to change the whole file, that's not your fault -- of course if you want to ... ;)).

Thanks for the patch, this behaviour was annoying me a bit as well in the past.


plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp
<http://git.reviewboard.kde.org/r/108305/#comment19211>

    Coding style: No spaces inside parentheses, should be:
    
    KUrl redirectionUrl(const Nepomuk2::Resource& res) {
    



plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp
<http://git.reviewboard.kde.org/r/108305/#comment19212>

    same here:
    
     if (res.hasType(NAO::Tag())) {


- Sebastian Kügler


On Jan. 9, 2013, 6 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108305/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 6 p.m.)
> 
> 
> Review request for Dolphin, Nepomuk and Plasma.
> 
> 
> Description
> -------
> 
>     NepomukRunner: Redirect the 'nepomuk:/res/uuid' urls before opening them
>     
>     The nepomuksearch kioslave has a special syntax which results in the the
>     searched term being displayed in "human terms" without the need for
>     stating the url. The nepomuk kioslave does not have this feature. It,
>     however, uses the nepomuksearch kioslave internally.
>     
>     Applications like Dolphin often do not stat a url before displaying it
>     in the title bar. This results in users seing an ugly "nepomuk - res -
>     uuid" in the title bar instead of the proper display name as set in the
>     UDSEntry.
>     
>     In order to avoid this ugly title bar, we manually redirect all nepomuk
>     urls to nepomuksearch before they are opened by the runner.
>     
>     It's a hack, but it works!
>     
>     BUG: 287259
> 
> @Dolphin people: I just thought you might want to know that this is something that will have to be fixed.
> 
> 
> This addresses bug 287259.
>     http://bugs.kde.org/show_bug.cgi?id=287259
> 
> 
> Diffs
> -----
> 
>   plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp 8075a6b 
> 
> Diff: http://git.reviewboard.kde.org/r/108305/diff/
> 
> 
> Testing
> -------
> 
> Yup
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130109/7b90b3a6/attachment.htm>