Review Request: Only use parallel sorting when sorting by name

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108309/
-----------------------------------------------------------

Review request for Dolphin.


Description
-------

It seems that comparing two dates is less reentrant than it might seem at first sight. In order to prevent crashes and other problems, I propose to only use multiple threads for sorting when sorting by "Name", because naturally comparing strings is the only expensive comparison function.

Does anyone see a problem with this? I really don't want to commit stupid new bugs at this point in the release cycle ;-)


This addresses bug 312679.
    http://bugs.kde.org/show_bug.cgi?id=312679


Diffs
-----

  dolphin/src/kitemviews/private/kfileitemmodelsortalgorithm.cpp 9588d19 

Diff: http://git.reviewboard.kde.org/r/108309/diff/


Testing
-------

Sorting works OK, verified that it uses only one thread when not sorting by name.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130109/33b280de/attachment.htm>