Review Request: Fix Bug 311794 - Additional information for audio files always shows duration of 00:00:00

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108281/#review25069
-----------------------------------------------------------

Ship it!


Thanks for the patch - I think many users will be happy that their music files have a reasonable duration again :-)

Just one little thing - the API docs for that function in the header file should also be fixed. But no new review is necessary for this, feel free to push (KDE/4.10 should be fine, given that is is a straightforward fix of an obvious mistake).

- Frank Reininghaus


On Jan. 8, 2013, 10:51 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108281/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 10:51 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Show the real audio file duration in additional informations
> 
> 
> This addresses bug 311794.
>     http://bugs.kde.org/show_bug.cgi?id=311794
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/knepomukrolesprovider.cpp 1bdac6d 
> 
> Diff: http://git.reviewboard.kde.org/r/108281/diff/
> 
> 
> Testing
> -------
> 
> Tested with various audio files ... worked fine
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130109/498f3a2f/attachment.htm>