Review Request: Fix Bug 312812 - The rename dialog should show the file name as plain text

Frank Reininghaus frank78ac at googlemail.com
Wed Jan 9 14:39:24 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108291/#review25067
-----------------------------------------------------------

Ship it!


Thanks, looks good! I'd also say that the patch is quite non-intrusive and will most likely not cause any regressions, so KDE/4.10 looks fine.

- Frank Reininghaus


On Jan. 9, 2013, 11:04 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108291/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 11:04 a.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Show the file name as plain text in the rename dialog
> 
> 
> This addresses bug 312812.
>     http://bugs.kde.org/show_bug.cgi?id=312812
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/renamedialog.cpp 65125c3 
> 
> Diff: http://git.reviewboard.kde.org/r/108291/diff/
> 
> 
> Testing
> -------
> 
> Tested with file name "<u><i>underlined and italic</i></u>" and it works
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130109/48e29257/attachment.htm>


More information about the kfm-devel mailing list