Review Request 109129: use plain text for information panel

Frank Reininghaus frank78ac at googlemail.com
Tue Feb 26 19:26:44 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109129/#review28169
-----------------------------------------------------------


Thanks for taking care of this issue so quickly! From my point of view, this patch is good for the KDE/4.10 branch, but I guess that this is up to the translators to decide, so I sent a request to their mailing list. Let's wait and see what they say.

- Frank Reininghaus


On Feb. 24, 2013, 8:21 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109129/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 8:21 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> This is the real fix mentioned in https://git.reviewboard.kde.org/r/108584/ , in this way we can use "real" plain text.
> 
> First, use PlainText for label, then change the @info to @label to avoid KLocalizedString add html tag.
> 
> (Can this commit to 4.10?)
> 
> 
> This addresses bugs 262464 and 315693.
>     http://bugs.kde.org/show_bug.cgi?id=262464
>     http://bugs.kde.org/show_bug.cgi?id=315693
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/informationpanelcontent.cpp 0c4c62f 
> 
> Diff: http://git.reviewboard.kde.org/r/109129/diff/
> 
> 
> Testing
> -------
> 
> &, &< &<>, AA<i>BB</i> now all ok.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130226/8753fe9b/attachment.htm>


More information about the kfm-devel mailing list