Review Request 108584: escape the string instead of set to plain text

Sun Feb 24 18:43:57 GMT 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108584/#review27972
-----------------------------------------------------------


It seems that this patch caused a regression: https://bugs.kde.org/show_bug.cgi?id=315693


- Frank Reininghaus


On Jan. 25, 2013, 9:13 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108584/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 9:13 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> See also: https://git.reviewboard.kde.org/r/108307/
> Due to the patch, now select multiple time in dolphin will have "<html>" tag shown, which is comes from KLocalizedString since @info indicates this is a rich string and add <html> automatically.
> 
> Either to change @info to @label or escape the string pass to setNameLabel can also solve the problem. Due to string freeze, here I choose to escape the string.
> 
> 
> This addresses bug 262464.
>     http://bugs.kde.org/show_bug.cgi?id=262464
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/informationpanelcontent.cpp 9b0dd00 
> 
> Diff: http://git.reviewboard.kde.org/r/108584/diff/
> 
> 
> Testing
> -------
> 
> test with AA<i>BB</i> in file name and panel, no problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130224/d17bfcc3/attachment.htm>