Review Request 109020: Dolphin: return focus to file view when pressing "enter" in filter bar

[Jens Rutschmann]

> On Feb. 19, 2013, 5:43 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! I'm sure that many users will appreciate this improvement. Looks good (except for the trailing white space, which shows up in red).
> > 
> > I think that this should go to the master branch only, because this is a behaviour change to add some convenience, rather than a bug fix. Moreover, I'd add a "default: break" at the end of the 'switch' statement, to be consistent with other places where Dolphin uses 'switch' statements.
> > 
> > Do you have commit access, or shall I push the change for you?

I've updated the patch according to your comments and also fixed the code comment.

Since I don't have commit access please push the change for me. Thanks !


- Jens


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109020/#review27733
-----------------------------------------------------------


On Feb. 19, 2013, 6:35 p.m., Jens Rutschmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109020/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 6:35 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> This patch slightly changes the behavior of the dolphin filter bar to return back focus to the file/folder view when pressing "return" or "enter".
> 
> The patch is inspired by the comments of Frank Reininghaus here: https://bugs.kde.org/show_bug.cgi?id=297140#c6
> 
> 
> This addresses bug 297140.
>     http://bugs.kde.org/show_bug.cgi?id=297140
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.h bc58531 
>   dolphin/src/dolphinviewcontainer.cpp b2c8605 
>   dolphin/src/filterbar/filterbar.h 9546c63 
>   dolphin/src/filterbar/filterbar.cpp f3076f0 
> 
> Diff: http://git.reviewboard.kde.org/r/109020/diff/
> 
> 
> Testing
> -------
> 
> I tried it on top of 4.10 and it works :-)
> 
> 
> Thanks,
> 
> Jens Rutschmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130219/9b21ffc2/attachment.htm>