Review Request 108989: Fix crash when clicking an action in the Places Panel context menu, and the corresponding device has been removed while the context menu was open

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108989/#review27683
-----------------------------------------------------------


This review has been submitted with commit 547d10aa16fb811df88a4804dc68410ebcd3ce73 by Frank Reininghaus to branch KDE/4.10.

- Commit Hook


On Feb. 17, 2013, 10:16 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108989/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2013, 10:16 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> After a context menu action has been clicked which needs to access a device, we have to check if the position of the device is still the same and adjust its index accordingly. More importantly, we also have to verify if the device is still there to prevent a crash.
> 
> 
> This addresses bug 315298.
>     http://bugs.kde.org/show_bug.cgi?id=315298
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placespanel.cpp 919f2ed 
> 
> Diff: http://git.reviewboard.kde.org/r/108989/diff/
> 
> 
> Testing
> -------
> 
> Cannot reproduce the crash any more. Could not see any regressions so far.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130218/e26cb398/attachment.htm>