Review Request 108976: Remove filtered items from the model if their parent is deleted
Commit Hook
null at kde.org
Mon Feb 18 22:53:45 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108976/#review27682
-----------------------------------------------------------
This review has been submitted with commit e053ecdcd57cc39fdcbc314fc8dd22c8b9dbdd4f by Frank Reininghaus to branch KDE/4.10.
- Commit Hook
On Feb. 15, 2013, 4:32 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108976/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2013, 4:32 p.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> When items are deleted, we do check if they are currently filtered and remove them from m_filteredItems if that is the case. However, we should also remove children of deleted expanded folders, even if these children are currently filtered.
>
>
> This addresses bug 315210.
> http://bugs.kde.org/show_bug.cgi?id=315210
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kfileitemmodel.cpp 6c015db
> dolphin/src/tests/kfileitemmodeltest.cpp 719459c
>
> Diff: http://git.reviewboard.kde.org/r/108976/diff/
>
>
> Testing
> -------
>
> Works. New and existing unit tests pass.
>
>
> Thanks,
>
> Frank Reininghaus
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130218/09fb51b5/attachment.htm>
More information about the kfm-devel
mailing list